Add right and left functor to BiFunctor #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
force-pushed
the
add-left-right-functor
branch
from
0d7f9af
to
466335e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 94.96% 94.97% +<.01%
==========================================
Files 241 241
Lines 4173 4199 +26
Branches 106 111 +5
==========================================
+ Hits 3963 3988 +25
- Misses 210 211 +1
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Aug 28, 2017
|
Could we use a Classes have a better binary compatibility story on 2.10 and 2.11 and I don't think we'll ever want to use these traits as mix-ins. |
|
Done :) |
|
Thanks! LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty, should resolve #1834.